HaschekSolutions / cryptotrader

This is an experimental trading bot framework written in PHP. It may contain bugs and should not be trusted with much money
Other
143 stars 49 forks source link

switch from gdax to Coinbase Pro #18

Closed genr8r closed 4 years ago

genr8r commented 4 years ago

Great work on implementing the API. I found it very helpful and thought I might return the favor by updating everything from gdax to coinbase pro. I tested the "examples", but not the "bots" or "wip". The examples worked great.

Almost all of my work was updating URL's and swapping out gdax references for the coinbase pro equivalents. It did feel heavy handed renaming the main file and the main class, but I wanted to be consistent. I also dropped the appropriate MacOS info into the readme.

Sorry I couldn't do this in smaller bites as I now it requires a quick review of almost every file, but again the changes are pretty minor. Hopefully bringing this up to date will keep it more useful for others. Thanks again for putting this together.

geek-at commented 4 years ago

Awesome, thanks