search

Haselnussbomber / HaselTweaks

A collection of quality of life tweaks and more.
GNU Affero General Public License v3.0
73 stars 9 forks source link

scrollable tabs crashes the game when scrolling beyond last tab in retainer inventory #98

Closed LastExceed closed 4 months ago

LastExceed commented 4 months ago

repro:

amazing plugin btw, thanks for your effort

Haselnussbomber commented 4 months ago

Are you using the chinese dalamud fork? It’s out of date by 3 weeks.

LastExceed commented 4 months ago

no, but now that you mention it i might still be on the stg branch from beta-testing. i'll check that

Haselnussbomber commented 4 months ago

Needs to be at least Dalamud 9.1.0.8. But maybe I copy pasted the number of tabs wrong during the cleanup. I’ll check soon, whenever I’m on my PC. :)

LastExceed commented 4 months ago

problem persists on stable branch (9.1.0.9)

Haselnussbomber commented 4 months ago

Yep, it’s my fault.

https://github.com/Haselnussbomber/HaselTweaks/blob/94ffe4eef126432eefa59689c07bd29442ef602b/HaselTweaks/Tweaks/ScrollableTabs.cs#L93 This should be 3. And the saddle bag has the same problem. Sorry!

Will fix sooon!

LastExceed commented 4 months ago

not if i fix it first!

Haselnussbomber commented 4 months ago

Fixed in v23.0.2. Thanks for reporting!