Tasklist (Pre-Deploy)

[milindalvares]

Okay, so we're almost there.

I've refactored a bunch of things. Mostly should work smoothly, but just keep an eye for where properties are being linked to (the url now includes /:slug). Images also have the property id in their name.

• [ ] Test the shit out of it. Vary the kinds of items of combinations. Next time we write unit tests for this shit, but this time it's gotta be manual.

Client said this stuff: Seems to work on my local server, so check it out.

A few small things;

• Toilets dont show up in the property specs
• Sanad; when you click on yes, still comes as No.
• Facilities and Built Up area should only show up when filled in.
• Basic alignment of the property specs (One below the other would be there)
• Price to show as Rs.3,00,00,000/- instead of Rs.30,000,000/-
• In Land Search, 1bhk, 2bhk, 3bhk should not come up. Settlement, Orchard and Agriculture should come. Also we posted a property today that showed up 4 times.

[alistair-rodrigues]

According to the client I have done the following changes

• Toilets dont show up in the property specs - DONE
• Sanad; when you click on yes, still comes as No. - DONE
• Facilities and Built Up area should only show up when filled in. - DONE
• Basic alignment of the property specs (One below the other would be there) - KEPT AS PER THE REPO
• Price to show as Rs.3,00,00,000/- instead of Rs.30,000,000/- - _DONE in property.erb _
• In Land Search, 1bhk, 2bhk, 3bhk should not come up. Settlement, Orchard and Agriculture should come. - DONE

@milindalvares

• Should I upload the same to the server for the client to review or first complete testing?
• The database is reset so the same will get uploaded to the server. is it OK?

[milindalvares]

Don't delete the old database, but yes, replace.

[alistair-rodrigues]

Please drop gpc-default-thumb.jpg in the dropbox

[alistair-rodrigues]

Just suggestions:

• Can the filters badge be more refined e.g. If in location filter we select mapusa which has 2 apartments then the apartments badge should reflect 2 and not the total number of apartments in North Goa. Because it gets confusing at times we wonder it shows eight but displays only two properties.
• Reset filters to default button.

[milindalvares]

@allyrods @hashaxel Check out the 'tests' branch for a behavioural change in the way filters work. Critical feedback is welcome on the direction.

[hashaxel]

As of now , besides the animations the reset is not functional. Have some concerns. Will share tomorrow. On 26-Aug-2014, at 7:43 am, Milind Alvares notifications@github.com wrote:

@allyrods @hashaxel Check out the 'tests' branch for a behavioural change in the way filters work. Critical feedback is welcome on the direction.

— Reply to this email directly or view it on GitHub.

[alistair-rodrigues]

• Reset filters will reset all the filters. What about individual filters. If all filters have an x mark (or whatever design element you want to use) to only clear that filter it would get better.
• Clicking any option of BHK collapses Type and Location filters.

[milindalvares]

• Done some changes to the image gallery. It works fine in development at least.
• The internal notes also works in development. If it doesn't work in production, remove the bit from the view but keep it going in the backend. We'll sort it out later.

[alistair-rodrigues]

• Image Gallery is functional in production.
• Internal notes also functional.

[hashaxel]

@allyrods

• [x] Internal Notes showing up on page. Meant for viewing only in backend.
• [x] The field 'Other Specifications' is not showing up on page.
• [x] Change 'Other Specifications' to 'More Information' and it should render last of all fields.
• [x] Correct duplication of property when a new one uploaded

@milindalvares

• [x] when 'Property Type' filter is selected, 'Location' filter shrinks too.
• [ ] Recently viewed properties has to be re-thought.

[milindalvares]

when 'Property Type' filter is selected, 'Location' filter shrinks too.

By design. Shows only locations which have properties of those type. Unless that's not the bug you're talking about.

[hashaxel]

@allyrods This is not reflecting on the live server.

when 'Property Type' filter is selected, 'Location' filter shrinks too. By design. Shows only locations which have properties of those type. Unless that's not the bug you're talking about.

[milindalvares]

@hashaxel @allyrods Hold on to that filter. Some bug has crept in.

[alistair-rodrigues]

The branch merged on the production is master are the changes in the master branch?

On 9 September 2014 15:47, hashaxel notifications@github.com wrote:

@allyrods https://github.com/allyrods

when 'Property Type' filter is selected, 'Location' filter shrinks too. By design. Shows only locations which have properties of those type. Unless that's not the bug you're talking about.

• This is not reflecting on the live server.

  — Reply to this email directly or view it on GitHub https://github.com/HashCookies/goaprop/issues/9#issuecomment-54949839.

Regards,

Alistair Rodrigues.

[milindalvares]

Pushed some code to the master. Let me know when deployed.

[milindalvares]

Note that the code will break wherever the _property.erb partial is called because it now requires another variable. Trying to find where all the calls are.

[milindalvares]

I also make a solemn oath never to share the DB again. so pains. much frustrating.

[hashaxel]

@milindalvares I think we are good to go. I like the idea of putting in the recently viewed properties side by side with recommendations, although, rendering the pin instead of just the title of the properties might lead to unnecessary scroll in cases where viewer checks out multiple properties. No?

[milindalvares]

Render what? (Is your sentence consistent with what you had to say?)

[hashaxel]

Let me break it down further. Right now, the recently viewed properties displays the tiles similar to the ones displayed in search results. My concern is when recently viewed properties are let's just say 6, those 6 tiles will add an unnecessary scroll. So why not just go with the title of the properties like before?

[milindalvares]

Recently viewed are capped at 3.

On 09-Sep-2014, at 5:20 pm, hashaxel notifications@github.com wrote:

Let me break it down further. Right now, the recently viewed properties displays the tiles similar to the ones displayed in search results. My concern is when recently viewed properties are let's just say 6, those 6 tiles will add an unnecessary scroll. So why not just go with the title of the properties like before?

— Reply to this email directly or view it on GitHub.

[hashaxel]

(Y)

[milindalvares]

You forgot the nipples. ( . Y . )

[hashaxel]

@allyrods Please make the changes live. Want to test with live content.

[hashaxel]

@allyrods One more thing, on the live server, the Porvorim tab in the Locations filter is larger than the rest.

• [x] Resolve the Porvorim tab

[milindalvares]

Still? With the new code?

On 09-Sep-2014, at 5:31 pm, hashaxel notifications@github.com wrote:

@allyrods One more thing, the Porvorim tab in the Locations filter is larger than the rest.

Resolve the Porvorim tab — Reply to this email directly or view it on GitHub.

[hashaxel]

We'll see when live.

[hashaxel]

Tried it locally and it works fine. — http://hashcooki.es

On Tue, Sep 9, 2014 at 5:35 PM, Milind Alvares notifications@github.com wrote:

Still? With the new code? On 09-Sep-2014, at 5:31 pm, hashaxel notifications@github.com wrote:

@allyrods One more thing, the Porvorim tab in the Locations filter is larger than the rest.

Resolve the Porvorim tab — Reply to this email directly or view it on GitHub.

---

Reply to this email directly or view it on GitHub: https://github.com/HashCookies/goaprop/issues/9#issuecomment-54959222

[alistair-rodrigues]

It's Live.

[hashaxel]

The block which shows similar properties is not rendering. — http://hashcooki.es

On Tue, Sep 9, 2014 at 5:55 PM, Alistair notifications@github.com wrote:

It's Live.

Reply to this email directly or view it on GitHub: https://github.com/HashCookies/goaprop/issues/9#issuecomment-54961074

[milindalvares]

Are you sure this is the case? If there aren't any similar properties, it won't render.

[alistair-rodrigues]

Its rendering here.

[hashaxel]

@milindalvares Maybe you're right. Can we then layout the recently viewed properties horizontally after the similar properties grid? Grid of 3 properties in a row would look tight enough. Might also help in cases no similar properties and an empty space showing up.

[milindalvares]

That'll happen when @allyrods deploys the new changes.

On 09-Sep-2014, at 6:18 pm, hashaxel notifications@github.com wrote:

@milindalvares Maybe you're right. Can we then layout the recently viewed properties horizontally after the similar properties grid? Grid of 3 properties in a row would look tight enough. Might also help in cases no similar properties and an empty space showing up.

— Reply to this email directly or view it on GitHub.

[milindalvares]

Not going to set them after the similar properties though. I wanted to tie visually keep recently-viewed close to the inquiry form.

[hashaxel]

@allyrods

• [x] Remove the sticky nav feature from the admin page.
• [ ] Price filter not accurate.
• [x] Update write up on Sell/Lease page. Pushed to tests branch.

[hashaxel]

@milindalvares Sticky nav causing issues on property search page as well with so many locations added.

[milindalvares]

Removed sticky from the js. And some misc changes.

[milindalvares]

Merged Tests branch.

[alistair-rodrigues]

Made the changes live.

[hashaxel]

@allyrods Pushed some content edit on services to master

[alistair-rodrigues]

noticing an error on server "App 22519 stderr: W, [2014-09-25T00:00:49.208504 #22538] WARN -- : attack prevented by Rack::Protection::SessionHijacking"

I guess it has something to do with our sessions usage in the app.

After this at some points there is a save error. Log file in dropbox

[alistair-rodrigues]

Things I am working on in new and edit views

• [x] Separate Facilities Field. (Swimming Pool, Gym etc.)
• [x] Different field from More Information with text area.
• [x] Field for Status
• [x] Field for Rate
• [x] A field for brokerage fee.
• [x] Age

[hashaxel]

@allyrods

• [x] Sanad box in the Land property when checked yes, still displays no on the page.

[alistair-rodrigues]

• [x] Option to switch off or switch on a property.

[hashaxel]

@allyrods @milindalvares

• [x] Landing page should have Residential property for Sale in North Goa pre-selected.
• [ ] Can we add markup language to avail minimal text formatting to the Facilities/More Information fields?

[alistair-rodrigues]

• [x] Option to put a Layout Plan.
• [x] Option to put up a Master Plan.
• [x] Requirement Form
• [x] Inquiry Form to have: Name, Number and E-mail ID and display Brokerage Fee

[milindalvares]

So I hear there aren't any errors in the multi hosts droplet GPC. @allyrods What's happening with the new 1GB droplet? Let me know if you aren't doing anything with it so I can delete it.

Milind

On 29-Sep-2014, at 1:58 pm, Alistair notifications@github.com wrote:

Option to put a Layout Plan. Option to put up a Master Plan. Requirement Form Inquiry Form to have: Name, Number and E-mail ID and display Brokerage Fee — Reply to this email directly or view it on GitHub.

[alistair-rodrigues]

If there are no complaints from GPC then you can go ahead and delete the droplet. I was working on it but if its not needed then delete it.

[alistair-rodrigues]

• [x] Arrange images in gallery in edit view.

@hashaxel @milindalvares done this but please check it from your side. Its live.