HashLips / hashlips_art_engine

HashLips Art Engine is a tool used to create multiple different instances of artworks based on provided layers.
MIT License
7.18k stars 4.3k forks source link

Possible bug Solana not updating baseUri #1128

Open fransyozef opened 2 years ago

fransyozef commented 2 years ago

I see in the code, there is no update for the baseUri at Solana network

https://github.com/HashLips/hashlips_art_engine/blob/main/utils/update_info.js

  if (network == NETWORK.sol) {
    item.name = `${namePrefix} #${item.edition}`;
    item.description = description;
    item.creators = solanaMetadata.creators;
  } else {
    item.name = `${namePrefix} #${item.edition}`;
    item.description = description;
    item.image = `${baseUri}/${item.edition}.png`;
  }

Is this correct?

bolshoytoster commented 2 years ago

@fransyozef I'm not familiar with solana, but I assume it's intentional since solana metadata doesn't create with a uri: https://github.com/HashLips/hashlips_art_engine/blob/d8ee279043d2d4a8de3bdfac0d89d0e966fb04a2/src/main.js#L144-L169

fransyozef commented 2 years ago

@bolshoytoster hmm true .. I thought Solana also uses baseUri . But, where does Solana get the image from then? Like which domain ?

image only contains the edition.

bolshoytoster commented 2 years ago

@fransyozef again, I've never touched solana, but I imagine the uri would be the same for any solana collection.

Indygreg317 commented 2 years ago

@bolshoytoster hmm true .. I thought Solana also uses baseUri . But, where does Solana get the image from then? Like which domain ?

image only contains the edition.

Did You Figure This Out? Any help would be awesome. Just start my journey..