Open Ahmeddh opened 2 years ago
Forked yesterday in order to accomplish exactly this – pushing an update by PM CST today with a EIP2981 compatible receiver along with a gas update for check addresses
Jon Greenwood GovernorDAO LLC @.*** Blockchain Integrations - Project Development
https://governordao.org/ Email : @.**@.>
From: Djobs @.> Sent: Friday, April 22, 2022 12:38 AM To: HashLips/hashlips_nft_contract @.> Cc: Subscribed @.***> Subject: [HashLips/hashlips_nft_contract] Implementing eip-2981 for royalties (Issue #63)
Hello there
if you read about eip-2981https://eips.ethereum.org/EIPS/eip-2981, it allows the contract to signal the royalty fees to marketplaces, its not yet supported by opensea, but other marketplaces like looksrare, superrare and rariple do support it
I know you may see that OS is the leader and the one with the most volume, but missing the royalty fees usually happens with other marketplaces that sometimes the contract creator has no clue that his collection is being sold there.
I'll try to implement it in the low gas contract and push it for @HashLipshttps://github.com/HashLips for review, but implementation from the man himself gives it more credibility with the community IMO
Thanks for reading
— Reply to this email directly, view it on GitHubhttps://github.com/HashLips/hashlips_nft_contract/issues/63, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATLQXJKKT7XVDFZAHHSLIC3VGI3KXANCNFSM5UBGSYKA. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>
Wonderful is there a way to test this on a testnet, hence opensea is not yet compatible with eip-2981 and they don't send royalties on their rinkeby testnet anyway
That was the problem I ran into only thing I can think of is to fork the entire ecosystem implementing the EIP and running in parallel for test purposes also could use the rarible contracts as a test based and then repoint towards OS at a later date
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Djobs @.> Sent: Friday, April 22, 2022 12:00:09 PM To: HashLips/hashlips_nft_contract @.> Cc: Jon G @.>; Comment @.> Subject: Re: [HashLips/hashlips_nft_contract] Implementing eip-2981 for royalties (Issue #63)
Wonderful, is there's a way to test this on a testnet, hence opensea is not yet compatible with eip-2981 and they don't send royalties on their rinkeby testnet anyway
— Reply to this email directly, view it on GitHubhttps://github.com/HashLips/hashlips_nft_contract/issues/63#issuecomment-1106697653, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATLQXJOLAOA2GGBJUO654W3VGLLJTANCNFSM5UBGSYKA. You are receiving this because you commented.Message ID: @.***>
Does rarible send royalties on testnet and are compatible with eip-2981?
@0xJonHoldsCrypto did this get implemented? Or is 2981 abandoned now? What is concensus on Royalties at the moment? Thx. : )
Hello there
if you read about eip-2981, it allows the contract to signal the royalty fees to marketplaces, its not yet supported by opensea, but other marketplaces like looksrare, superrare and rariple do support it
I know you may see that OS is the leader and the one with the most volume, but missing the royalty fees usually happens with other marketplaces that sometimes the contract creator has no clue that his collection is being sold there.
I'll try to implement it in the low gas contract and push it for @HashLips for review, but implementation from the man himself gives it more credibility with the community IMO
Thanks for reading