Is this dApp compatible with ERC721a ?

HashLips / hashlips_nft_minting_dapp

HashLips minting dapp is a quick and easy way to connect your smart contract and start minting NFTs.

MIT License

1.02k stars 984 forks source link

Is this dApp compatible with ERC721a ? #113

Open andreleo6 opened 2 years ago

andreleo6 commented 2 years ago

Hi. I was wondering if this dApp can be used with an erc721a smart contract? I know this dApp calculates the suggested gas by multiplying a value for the number of NFTs to mint. So will this still make people pay the same as if they were minting on a normal erc721. And if so, by not multiplying the gas limit for the amount of NFTs to mint, would this fix the problem?

UmbrellaC0rp commented 2 years ago

I'm also curious about this. On my tests with an ERC721A contract linked to the dapp, the gas fees did seem lower on batch mints, but I never thought about what you've mentioned in this issue!

BedoSensei commented 1 year ago

I'm also interested by the answer. I have tried to mint a batch of ERC721A NFT by using remix and the dapp at the same time. Obviously, the gas fees are much higher with the dapp. I'm looking how to change the GAS LIMIT value in config .json ...

BedoSensei commented 1 year ago

Ok it looks like I've found the solution :

Delete in config.json this entire line :

"GAS_LIMIT": ..... Save

Then go to the App.js and delete these entire lines located in const claimNFTs :

let totalGasLimit = String............
console.log("Gas limit",..................
gasLimit: String{totalGasLimit}

Save. By deleting these parameters, all seems to work.

m1ckc3s commented 1 year ago

@BedoSensei will this make metamask automatically calculate the gas?

BedoSensei commented 1 year ago

@BedoSensei will this make metamask automatically calculate the gas?

@m1ckc3s It works for me, yes. I know however that Hashlips is currently working on the new versions, maybe it is now automatically included in it.