HashLoad / boss

Dependency Manager for Delphi and Lazarus
https://t.me/hashload
MIT License
533 stars 95 forks source link

Wrong paths added to the project search path? #156

Open Spelt opened 10 months ago

Spelt commented 10 months ago

Hi

I manage ZXing for Delphi and I need a little help in order to support Boss properly. I have uploaded the boss.json here: https://github.com/Spelt/ZXing.Delphi/blob/v_3.0/boss.json

The problem is the line "mainsrc": "Lib/Classes/",

It seems right but all other paths next to Lib are also added to the path. For example the this path is added: modules\ZXing.Delphi\UnitTest

I would expect only everything in: modules\ZXing.Delphi\Lib\Classes

Or am I doing something wrong here?

Thanks! Edward

viniciussanchez commented 6 months ago

Normally he takes the first folder... it could be a bug in the boss. Until then I always only worked with "/src" for example.

andriwsluna commented 6 months ago

@Spelt , i installed your packge here and boss added only de lib/classes folder and your sub folders: modules\ZXing.Delphi\Lib\Classes\1D Barcodes; ..\modules\ZXing.Delphi\Lib\Classes\1D Barcodes; modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Decoder; ..\modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Decoder; modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Detector; ..\modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Detector; modules\ZXing.Delphi\Lib\Classes\2D Barcodes; ..\modules\ZXing.Delphi\Lib\Classes\2D Barcodes; modules\ZXing.Delphi\Lib\Classes\Common\Detector; ..\modules\ZXing.Delphi\Lib\Classes\Common\Detector; modules\ZXing.Delphi\Lib\Classes\Common\ReedSolomon; ..\modules\ZXing.Delphi\Lib\Classes\Common\ReedSolomon; modules\ZXing.Delphi\Lib\Classes\Common; ..\modules\ZXing.Delphi\Lib\Classes\Common; modules\ZXing.Delphi\Lib\Classes\Filtering; ..\modules\ZXing.Delphi\Lib\Classes\Filtering; modules\ZXing.Delphi\Lib\Classes; ..\modules\ZXing.Delphi\Lib\Classes

The "modules\ZXing.Delphi\UnitTest" are not added. Try to upgrade boss version.

Spelt commented 6 months ago

Hi,

Thanks that works but I now see another problem. The folders are added twice ! One with the right path and one with the wrong path.

Like:

modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Decoder; ..\modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Decoder;

On Thu, 30 May 2024 at 00:38, Andriws Luna @.***> wrote:

@Spelt https://github.com/Spelt , i installed your packge here and boss added only de lib/classes folder and your sub folders: modules\ZXing.Delphi\Lib\Classes\1D Barcodes; ..\modules\ZXing.Delphi\Lib\Classes\1D Barcodes; modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Decoder; ..\modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Decoder; modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Detector; ..\modules\ZXing.Delphi\Lib\Classes\2D Barcodes\Detector; modules\ZXing.Delphi\Lib\Classes\2D Barcodes; ..\modules\ZXing.Delphi\Lib\Classes\2D Barcodes; modules\ZXing.Delphi\Lib\Classes\Common\Detector; ..\modules\ZXing.Delphi\Lib\Classes\Common\Detector; modules\ZXing.Delphi\Lib\Classes\Common\ReedSolomon; ..\modules\ZXing.Delphi\Lib\Classes\Common\ReedSolomon; modules\ZXing.Delphi\Lib\Classes\Common; ..\modules\ZXing.Delphi\Lib\Classes\Common; modules\ZXing.Delphi\Lib\Classes\Filtering; ..\modules\ZXing.Delphi\Lib\Classes\Filtering; modules\ZXing.Delphi\Lib\Classes; ..\modules\ZXing.Delphi\Lib\Classes

The "modules\ZXing.Delphi\UnitTest" are not added. Try to upgrade boss version.

— Reply to this email directly, view it on GitHub https://github.com/HashLoad/boss/issues/156#issuecomment-2138370223, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADAS3VIMLYA4UMIH7Q2TWCDZEZKGHAVCNFSM6AAAAABCPPEG7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZYGM3TAMRSGM . You are receiving this because you were mentioned.Message ID: @.***>

andriwsluna commented 6 months ago

This is cause by this PR. I don't know exactly why this adjustment

I believe this is for cases where Dproj is in a subfolder in relation to boss.json. But I think it would be better solved using the "projects" array in boss.json

Spelt commented 6 months ago

Yes I think so too. Op 1 jun 2024 om 15:51 heeft Andriws Luna @.***> het volgende geschreven: This is cause by this PR. I don't know exactly why this adjustment

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>