Support heroku-20 and gigalixir-20 - Githubissues

HashNuke / heroku-buildpack-elixir

Heroku Buildpack for Elixir with nitro boost

MIT License

810 stars 304 forks source link

Support heroku-20 and gigalixir-20 #191

Closed jesseshieh closed 3 years ago

jesseshieh commented 3 years ago

Uses hex's otp builds for heroku-20 and gigalixir-20 and continues using the same builds for all other stacks. Eventually, we'll try to migrate all builds to hex's.

@KazW do you mind taking a look at this?

tielur commented 3 years ago

If I use heroku buildpacks:set hashnuke/elixir should this be fixed there? I just upgraded my heroku app to Heroku-20 and I'm still getting errors:

       * MIX_ENV=prod
-----> Stack changed, will rebuild
-----> Fetching Erlang 22.0.3
-----> Installing Erlang 22.0.3 (changed)
-----> Fetching Elixir v1.8.2 for OTP 22
-----> Installing Elixir v1.8.2 (changed)
-----> Installing Hex
/app/.platform_tools/erlang/erts-10.4.2/bin/beam.smp: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
-----> Installing rebar
/app/.platform_tools/erlang/erts-10.4.2/bin/beam.smp: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
-----> Fetching app dependencies with mix
/app/.platform_tools/erlang/erts-10.4.2/bin/beam.smp: error while loading shared libraries: libtinfo.so.5: cannot open shared object file: No such file or directory
 !     Push rejected, failed to compile Elixir app.
 !     Push failed

jesseshieh commented 3 years ago

Unfortunately not, I think you have to use https://github.com/HashNuke/heroku-buildpack-elixir hashnuke/elixir is pinned to a pretty old version I think.

tielur commented 3 years ago

Unfortunately not, I think you have to use https://github.com/HashNuke/heroku-buildpack-elixir hashnuke/elixir is pinned to a pretty old version I think.

Is this something you guys maintain?

tielur commented 3 years ago

If not then it would be nice to update the README to mention that, because it just specifies the non-git version

tielur commented 3 years ago

Ok it does look old 😆

heroku buildpacks:versions hashnuke/elixir

Version  Released At               Status
───────  ────────────────────────  ─────────
1        2018-07-06T13:38:47.185Z  published

I switched over to https://github.com/HashNuke/heroku-buildpack-elixir.git#b9092d471ebb0163dbf1bf733b719cf1e31c8f64 but I'm still getting the same error

tielur commented 3 years ago

I had to clear my build cache for this to work https://help.heroku.com/18PI5RSY/how-do-i-clear-the-build-cache

Sorry for the rubber duck comments on this PR

KazW commented 3 years ago

@jesseshieh Sorry I haven't been around to respond, I've been busy at work. I have some concerns with this approach:

New Heroku stacks could break this, when there are multiple stacks that are supported that have different library locations, this approach will break.
What else is in this build from Hex? If it has the UI libraries (wx), this is going to take away space that devs can use.
There's no automated way to add versions to this buildpack, meaning that devs are still waiting for the latest OTP/Elixir version to be added to the repos before they can use it.

I think this patch is a deferral of the problem and not a solution to it.