HashNuke / heroku-buildpack-elixir

Heroku Buildpack for Elixir with nitro boost
MIT License
813 stars 311 forks source link

Build isn't marked as failing if errors occur #195

Closed edmorley closed 3 years ago

edmorley commented 3 years ago

In #194 errors occurred during the build, however the build was still marked as successful, since it exited zero.

This resulted in boot time failures instead, which is much worse, since it can take down an already-deployed app.

To resolve this, bash exit on error mode should be used to ensure errors are caught during the build itself.

See also: http://redsymbol.net/articles/unofficial-bash-strict-mode/