search

HashNuke / hound

Elixir library for writing integration tests and browser automation
http://hexdocs.pm/hound
MIT License
1.36k stars 145 forks source link

Should all retries load from :retries configuration value? #249

Open ibarrae opened 4 years ago

ibarrae commented 4 years ago

Hi folks, first let me thank and congratulate you for this library, it has been great and really helpful :tada:.

My following doubt is the following:

Shouldn't all default "retries" arguments load from this retries function?

I have seen that functions like search_element and find_all_elements that have a default of "5". Making it hard to use the "configurable" value. Maybe I'm doing something wrong or what could be done to use "configurable" value by default on these functions?

Thanks in advance for the help!

danhper commented 4 years ago

Hi! This would indeed be a much better behaviour. I do not have much time right now but if you want to send a PR to fix this it would be very welcome. Thanks!