search

HashandSalt / Kirby3-Gilmour

A small plugin to with ID3 tags on audio files.
MIT License
5 stars 1 forks source link

[K4] 4.0 Compatibility #2

Open afbora opened 9 months ago

afbora commented 9 months ago

Array and string offset access syntax with curly braces is no longer supported \site\plugins\Kirby3-Gilmour-master\vendor\james-heinrich\getid3\getid3\getid3.php:554

Kirby 4.0.0-rc.4 PHP 8.1.23

plagasul commented 7 months ago

From this message it seems that the problem is with the underlying getid3 library. The version used by this plugin does not support php 8.1. Support for 8.1 was added on v1.9.23-20231019084 which is the one that composer updates to.

I cloned that version of getid3 locally and demos work.

I then cloned this repo, used composer to update getid3, then copied the whole thing into site/plugins/ and it does seem to work well :))