reloadTable() method in ProfilePanel contains multiple smells

[ahan10]

• It is responsible for loading and reloading the data into the tables, and it is a large method.
• UserDao, ComicBookReadingListDao and ComicBookFinishedListDao objects are being created multiple times, it should be a global object and that instance should be used for one session, currently multiple objects are being created.
• Abstraction of client code and database not done as Dao’s are being used directly instead of through a service layer.
• Similar names for readingList and readList, it was confusing to read the code, readingList can be renamed to finishedList.
• Currently there is controller code inside the GUI code (mouseListener), this should be moved to the controller class.
• Improper handling for UserIDDoesNotExistException.
• Code duplication, the lists are being converted from entity type to Dto type in two steps, this can be done using the ComicBookMapper class, and code duplication can be removed.
• Values for setBounds are hard coded, similar values can be clubbed together and converted to constants.
• Long parameter list, variable of the same type can be clubbed together and be denoted by commas.

[Hashir-Jamil]

We will leave this issue open but it will most likely not be addressed in time for Delivery 2. There is not enough time to do a major refactor like this at this stage.

This issue won't come up when the project is ported due to the differences between a framework like swing and a javascript front end framework