Improper abstraction of database form client code

Hashir-Jamil / LongBox

MIT License

1 stars 1 forks source link

Improper abstraction of database form client code #18

Open ahan10 opened 7 months ago

ahan10 commented 7 months ago

Multiple instance of the code does not follow the abstraction, they are directly accessing the Dao directly instead of via the service layer. This can be found in:

ComicBookInfoController: Implementation of favourites button, reading button and finished button still directly communicate with Dao instead of via a service layer.
reloadTables() method of ProfilePanel.
actionPerformed() of ProfileController

Hashir-Jamil commented 7 months ago

We will leave this issue open but it will most likely not be addressed in time for Delivery 2. There is not enough time to do a major refactor like this at this stage.