search

Hashir-Jamil / LongBox

MIT License
1 stars 1 forks source link

[BR9] Service Layer is Not Used Consistently For Database Interaction and User Session Management #9

Closed Hashir-Jamil closed 7 months ago

Hashir-Jamil commented 7 months ago

In the Authentication Controller class, the data access layer is not fully abstracted away from the controller layer by using the service layer as the middle class.

The major suggestion is to use dependency injection to only create a user service instance in the authentication controller and let the service layer be given the data access object independently of the controller.

ahan10 commented 7 months ago

Removed UserDao instance from controller, it is now passed via the main method, making it abstract. https://github.com/Hashir-Jamil/LongBox/commit/248a879600b9da5f01906cc30937c513d4cd2c8a