HashtagSell / posting-api

API for storage and retrieval of posting details for Hashtagsell
0 stars 0 forks source link

Search "coffee+table" vs. "coffee table". #67

Closed that1guy closed 9 years ago

that1guy commented 9 years ago

Hi Josh,

Now that we have such little data and ebay data isn't as pure this issue seems to expose itself pretty loudly and kinda makes our search engine show "silly results". An example of this is the search for "coffee table".

https://staging.hashtagsell.com/q/coffee%20table

This will show coffee mugs, cups, coffee beans, etc. Can we resolve this by returning results that have both the word "coffee" and "table" in them? Will this impact the product in a negative way in other areas?

Think this issue is slightly linked to #40

brozeph commented 9 years ago

ES does support usage of keywords like "AND" and "OR"...

With AND vs. Without AND

Should we try doing something along these lines to ratchet down the search results?

that1guy commented 9 years ago

With AND looks MUCH better. This got me thinking though. Shouldn't AND boolean logic only be applied to popcat and /suggested endpoints? Let me explain. Today by passing macbook%20air into popcat or /suggested we are getting back a top category of VPAR (auto parts)... If popcat and /suggested were running AND condition then they would certainly come back with SELE (for sale electronics).. My point is shouldn't the AND functionality only be applied to popcat and /suggested, not the search itself, and this will result in best results?

that1guy commented 9 years ago

Also, if popcat and /suggested endpoints use AND condition and come back with nothing shouldn't these resources fall-back to not using AND condition. For example someone searches for:

"Black mustang custom rims"

This could be problematic with AND logic. So probably build in fall-back.

brozeph commented 9 years ago

This seems like a good idea to use AND consistently across /suggested and /popular - the fall back could be a tad tricky though. If someone truly is looking for an Apple Watch, showing them a bunch of Apple accessories or Citizen watches may be completely counter intuitive.

that1guy commented 9 years ago

Okay, lets implement AND functionality. Then in fallback query can we just the elasticserach fuzzy capabilities instead?

that1guy commented 9 years ago

Hi Josh,

I believe I've deployed all the most recent code to staging but I'm seeing an issue where /popcat and /suggested resources return different categories. The problem here is when you sell a #macbook air /suggested puts the item in the SELE category, but when you search for "macbook air" the /popular resource returns the SAPL category, thus the item you just sold might not always show up in search results.

Believe this is caused because /suggested is using CL data to make category predictions and /popular is only using the ebay data we ingested, correct?

Discuss in the morning. Cheers!

brozeph commented 9 years ago

Assigning to @that1guy for verification - search results seem much tighter after these tweaks

that1guy commented 9 years ago

Better! Thanks Josh, working really well on my end.