search

HashtagSell / posting-api

API for storage and retrieval of posting details for Hashtagsell
0 stars 0 forks source link

Transaction creation not only removes item from search engine, but all the sellers MyPosts #90

Open that1guy opened 8 years ago

that1guy commented 8 years ago

Hi Josh,

https://github.com/HashtagSell/posting-api/blob/develop/lib/data/postings.js#L618

As it stands now, after a buyer and seller have agreed to meet, and a transaction ID has been created, the item will no longer appear in the search, as expected. However, by removing the item from ES entirely the posting will no longer appear in the seller's My Posts and the Buyer's Watchlist.

Seems we need to "flag" the item as pending and not remove from ES completely. I plan on taking a look at doing this later tonight, but for now I going to push past this.

Thanks for taking a look if you beat me to it.

that1guy commented 8 years ago

Devin and I have discussed this. We believe the item needs to stay in inventory until the review process has confirmed the item has been sold. we need to remove item from ES index after the buyer or seller have confirmed they have exchanged the item.

brozeph commented 8 years ago

Assigning to @that1guy for verification