HasithDeAlwis / Hasith-Portfolio-v2

Version two of my portfolio
0 stars 0 forks source link

20/hasith/repo/change project directories #22

Closed HasithDeAlwis closed 2 months ago

HasithDeAlwis commented 2 months ago

🛠 Changes being made

✨ What's the context?

We need separate directories to streamline dev and not have a crowded workspace

🧠 Value proposition of the Infrastructure

It will allow streamless workflow in the repo as project gets larger. Also opens us to using microservices and advanced FE architecture down the line

Summary by Sourcery

Reorganize the project structure by moving components into separate directories under '/apps', update configurations and documentation to reflect these changes, and enhance the build and CI processes to align with the new structure.

Enhancements:

Build:

CI:

Documentation:

Tests:

Chores:

netlify[bot] commented 2 months ago

Deploy Preview for hasith failed. Why did it fail? →

Name Link
Latest commit a5abef9f8038820c91e015f9d3c3f44b2b96a071
Latest deploy log https://app.netlify.com/sites/hasith/deploys/66edcd5c1176bd0008415ec0
sourcery-ai[bot] commented 2 months ago

Reviewer's Guide by Sourcery

This pull request implements a significant restructuring of the project directories, moving components into separate directories under /apps. The changes include updates to configuration files, component adjustments, and modifications to build and test scripts to accommodate the new structure.

File-Level Changes

Change Details Files
Restructured project directories
  • Created separate directories under /apps for website, website-e2e, payload (CMS), and storybook
  • Updated README to reflect new project structure
  • Modified import paths in various files to align with new directory structure
README.md
apps/website/src/pages/index.astro
apps/storybook/.storybook/main.ts
apps/website/astro.config.mjs
Updated configuration files
  • Modified tsconfig.json to remove Astro-specific configurations
  • Updated tailwind.config.mjs with new content paths and color definitions
  • Changed eslint.config.js to include Svelte linting
  • Created separate tsconfig.json files for website, website-e2e, and storybook
tsconfig.json
tailwind.config.mjs
eslint.config.js
apps/website/tsconfig.json
apps/website-e2e/tsconfig.json
apps/storybook/tsconfig.json
Adjusted component styling and functionality
  • Modified button component variants and colors
  • Updated card component text color
  • Relocated Storybook stories to a dedicated stories directory
apps/website/src/components/ui/button/index.ts
apps/website/src/components/ui/button/button.svelte
apps/website/src/components/index/card.svelte
apps/storybook/stories/index/card.stories.svelte
apps/storybook/stories/ui/button.stories.svelte
Updated build and test configurations
  • Modified E2E and unit test GitHub Actions workflows
  • Updated Playwright configuration for E2E tests
  • Changed Vitest configuration for unit tests
  • Removed Netlify configuration and switched to static output in Astro config
.github/workflows/E2E-TEST.yml
.github/workflows/unit-test.yml
apps/website-e2e/playwright.config.ts
apps/website/vitest.config.ts
apps/website/astro.config.mjs
netlify.toml

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.