Improve interface of generated code

Haskell-OpenAPI-Code-Generator / Haskell-OpenAPI-Client-Code-Generator

Generate Haskell client code from an OpenAPI 3 specification

46 stars 19 forks source link

Improve interface of generated code #23

Closed joel-bach closed 4 years ago

joel-bach commented 4 years ago

Do not catch exceptions for user
Improve monad containing configuration
Make the monad operation function the default

See https://github.com/Haskell-OpenAPI-Code-Generator/Haskell-OpenAPI-Client-Code-Generator/issues/9

The changes made by this PR are best visible in the changed Stripe example: https://github.com/Haskell-OpenAPI-Code-Generator/Stripe-Haskell-Library/pull/3/files#diff-7f6666bd3cb88c8284fab86dfb0de42d

In addition, this is a screenshot of the Haddock for GetEvents:

NorfairKing commented 4 years ago

This looks so much better, I'm excited!!

joel-bach commented 4 years ago

IMO, the most important issues which introduce big breaking changes are done. Now I was wondering: Are there more critical issues which you would like to have resolved before updating the Stripe library and adapting your code to check if everything works fine for you?

NorfairKing commented 4 years ago

@joelfisch We should probably try it out together in pair-programming on a call. Then we'll discover the issues together. No need to update the hackage library until we get that done. I can just depend on a repo.

joel-bach commented 4 years ago

Perfect, this sounds good 👍

Are you available this evening?

NorfairKing commented 4 years ago

@joelfisch Yes, feel free to schedule something. See cs-syd.eu/agenda.