search

Haskell-OpenAPI-Code-Generator / Haskell-OpenAPI-Client-Code-Generator

Generate Haskell client code from an OpenAPI 3 specification
46 stars 19 forks source link

Feat/bump stackage resolver #66

Closed thomasbach-dev closed 2 years ago

thomasbach-dev commented 2 years ago

With this we update to GHC 8.10.7. As described in the latest commit, I reran code generation for the example directory and golden tests. Everything was stable. So I guess we should be good here. :)

NorfairKing commented 2 years ago

It's important to update the nixpkgs version then too. You should use lts-18.16 and nix-shell --command 'niv update nixpkgs --branch nixos-21.11'

thomasbach-dev commented 2 years ago

Cool, I already wanted to open a ticket requesting for a version bump in the nix machinery. I'll adapt things.

@NorfairKing What's the motive behind using 18.16? Is it because nix is pinned to this?

NorfairKing commented 2 years ago

Is it because nix is pinned to this?

Yup.

thomasbach-dev commented 2 years ago

One more thing related to this: there is a definition to generate a stack.yaml file https://github.com/Haskell-OpenAPI-Code-Generator/Haskell-OpenAPI-Client-Code-Generator/blob/master/openapi3-code-generator/src/OpenAPI/Generate/IO.hs#L85 which uses 15.3 as a resolver. Should that be bumped too? (I actually think it should be dropped.)

joel-bach commented 2 years ago

This looks good to me :+1:

The bump on the generated stack.yaml is correct as well. We could drop it as I think it is not very useful in practice. Currently, it is used for the tests so I would leave it for now as it is not really a pain-point as far as I am concerned. Please correct me if it is for you.