search

Haskell-OpenAPI-Code-Generator / Haskell-OpenAPI-Client-Code-Generator

Generate Haskell client code from an OpenAPI 3 specification
46 stars 19 forks source link

updates for template-haskell >= 2.17.0 #72

Closed stepcut closed 2 years ago

stepcut commented 2 years ago

Some small updates to support template-haskell >= 2.17.0.

NorfairKing commented 2 years ago

Does CI test with this newer version? How did you check that this works?

stepcut commented 2 years ago

I only tested it by building it locally using GHC 9.2.1 and GHC 8.10.7. I also ran the executable I built with GHC 9.2.1 against the mailchimp marketing API and it generated code that compiled. I have yet to actually use that code to make an API call to the mailchimp API.

The existing circleci testsuite passed, but I did not do anything to update it to test against GHC 9.x -- so I would guess it is not testing against newer GHC yet.

joel-bach commented 2 years ago

Hey there, I updated the code in this commit to include your proposal for the TH upgrade, thank you :smile:

The polarity fix has been included as part of https://github.com/Haskell-OpenAPI-Code-Generator/Haskell-OpenAPI-Client-Code-Generator/commit/cddc4f40e02c1b130fc1c405952d05e072d694ff.

Since both relevant changes of this PR are now part of master, I'll close this PR. Thank you for your help.