search

Haskell-OpenAPI-Code-Generator / Haskell-OpenAPI-Client-Code-Generator

Generate Haskell client code from an OpenAPI 3 specification
46 stars 19 forks source link

Change Path package import to enable to work with Windows paths #86

Closed lauraschauer closed 1 year ago

lauraschauer commented 1 year ago

Change import statement from import Path.Posix to import Path to avoid bugs when building the library on a Windows OS. Importing Path on its own is usually better: Hackage Path.

joel-bach commented 1 year ago

Hey @lauraschauer , thank you for your PR! The change looks good from my POV. The only thing I would like to ask you is to run the pre-commit hooks before committing (the easiest way is to run nix-shell to install them). This runs in particular ormolu for the formatting which was missed here as you can see from this failed CI run (it is a super small thing, only about the order of the imports). Once that is done and CI passes I am happy to merge :smile:

lauraschauer commented 1 year ago

Okay, this should hopefully be fixed now :)