search

Haskell-OpenAPI-Code-Generator / Haskell-OpenAPI-Client-Code-Generator

Generate Haskell client code from an OpenAPI 3 specification
46 stars 19 forks source link

Issue with HMRC's VAT API #94

Closed locallycompact closed 6 months ago

locallycompact commented 7 months ago

Trying to use this tool to convert the specification here: https://developer.service.hmrc.gov.uk/api-documentation/docs/api/service/vat-api/1.0/oas/page

Results: vat

vat2

NorfairKing commented 6 months ago

@joel-bach I guess multipleOf doesn't allow for non-integer values. Is that according to spec?

joel-bach commented 6 months ago

I had a look at the spec which does only mention this to be a number greater than zero. Therefore I think the presented specification is indeed valid and it is a parsing problem on our side. Considering that the code generator does not do anything with that value, I am in favor of changing it to allow floating point numbers as well. I'll have a look tomorrow.

joel-bach commented 6 months ago

Hey @locallycompact , this should be fixed by https://github.com/Haskell-OpenAPI-Code-Generator/Haskell-OpenAPI-Client-Code-Generator/pull/95 which has been merged to master. I'll close this issue as I am confident with the fix but please let me know if it does not work for some reason 🙏