search

Haskell-Things / HSlice

HSlice - A Haskell based slicer for 3D printing.
https://implicitcad.org/
GNU Affero General Public License v3.0
76 stars 5 forks source link

Remove warnings; fix haddocks #33

Closed fisx closed 3 years ago

fisx commented 3 years ago

I'm doing this mostly to see if the github actions are working, but the changes should be marginally useful in itself, too. (Unless you hate them, because you're planning to add those imports again soon. In that case: sorry :))

fisx commented 3 years ago

With 98fa4ac0dc545027bba9808b1b8493a92f1c2e23 I had to guess a bit what you meant, especially with the haddock line at the bottom of the module. Hope I've got it right!

sorki commented 3 years ago

Made couple of changes to github-actions-dhall/haskell-nix.dhall, should get picked up next time you run ci.sh. Fixes caching and switches to ubuntu-latest (Currently 20.04) by default.

fisx commented 3 years ago

Made couple of changes to github-actions-dhall/haskell-nix.dhall, should get picked up next time you run ci.sh. Fixes caching and switches to ubuntu-latest (Currently 20.04) by default.

Thanks! 70e94f7

fisx commented 3 years ago

Ah! the problem in 0abcabd was that my branch was not up to date with master any more, but the CI merges master before running all tests. Makes sense, but I wonder if we can make this less confusing by complaining about not being merged, and failing early?

fisx commented 3 years ago

Also: stop merging stuff, @julialongtin ! :)