search

Haskell-Things / ImplicitCAD

A math-inspired CAD program in haskell. CSG, bevels, and shells; 2D & 3D geometry; 2D gcode generation...
https://implicitcad.org/
GNU Affero General Public License v3.0
1.41k stars 142 forks source link

extopenscad: trigonometric functions aren't compatible with openscad #201

Open l29ah opened 6 years ago

l29ah commented 6 years ago

In openscad they take degrees, while in implicitcad they take radians, but it is never mentioned anywhere.

julialongtin commented 6 years ago

I'm actually good with this, but i think that a compatibility flag makes sense. similar to $RES to set the resolution, $babylonian to use 360 degree notation.

elimohl commented 6 years ago

It is really strange that trigonometric functions take radians but rotation takes degrees.

acwest commented 5 years ago

I have written a LOT of geometry library code for OpenSCAD that would be broken by this. I like the idea of a compatibility flag, as I never really liked the way the trig functions work in degrees for OpenSCAD

julialongtin commented 5 years ago

I'll be adding a flag for this shortly.

julialongtin commented 2 years ago

A flag for this has been added and merged. please check if enabling the openscad compatibility flag fixes this for you.