Haskell-Things / ImplicitCAD

A math-inspired CAD program in haskell. CSG, bevels, and shells; 2D & 3D geometry; 2D gcode generation...
https://implicitcad.org/
GNU Affero General Public License v3.0
1.33k stars 141 forks source link

Radians vs degrees for SCAD trigonometric functions #415

Open sorki opened 2 years ago

sorki commented 2 years ago

Currently, our trig. functions work with radians but the reference implementation uses degrees. This can cause surprises as the SCAD file is interpreted incorrectly.

We can

Related to this, @julialongtin proposed exposing ImplicitCAD (or Implicits SCAD engine) version as SCAD variable which could potentially be used to guard breaking changes.

sorki commented 2 years ago

Gets even more confusing because e.g. rotate already uses degrees.