search

Haskell-Things / ImplicitCAD

A math-inspired CAD program in haskell. CSG, bevels, and shells; 2D & 3D geometry; 2D gcode generation...
https://implicitcad.org/
GNU Affero General Public License v3.0
1.41k stars 142 forks source link

merged version of lepsa:improving-shell #468

Closed julialongtin closed 11 months ago

julialongtin commented 11 months ago

from @lepsa: Fixing an issue in shell where it was causing the object to increase in size, proportional to the width value passed into shell.

shell now works by taking the difference of the original object and the same object with a negative outset applied. This process does not change the outside dimentions of the resulting object when compared to the original.

Adding a new golden test that can also be used to visually check that shell isn't changing outside dimentions. Updating the wheel-well STL file as it depends on shell

lepsa commented 11 months ago

Thanks @julialongtin. I should have some to maybe poke at this code again soon