Haskell-Things / ImplicitCAD

A math-inspired CAD program in haskell. CSG, bevels, and shells; 2D & 3D geometry; 2D gcode generation...
https://implicitcad.org/
GNU Affero General Public License v3.0
1.39k stars 142 forks source link

weird spikes #64

Closed timthelion closed 7 years ago

timthelion commented 12 years ago
>import Graphics.Implicit.Primitives
>import Graphics.Implicit
>import Data.NumInstances

>main =
> writeSTL
>  1
>  "foo.stl" $
>  squarePipe (10,10,10) 1 30 -- Change this value up or down, from 30 try 10 or 100, neither have spikes

>squarePipe
> (x,y,z)
> diameter
> precision
>  =
> union $
> map
>  (\start->
>    translate
>     start
>     (rect3R 0 (0,0,0) (diameter,diameter,diameter))) $
> zip3
>  (map (\n->(n/precision)*x) [0..precision])
>  (map (\n->(n/precision)*y) [0..precision])
>  (map (\n->(n/precision)*z) [0..precision])
timthelion commented 12 years ago

Hmm, actually you don't need Data.NumInstances there... Sorry.

colah commented 12 years ago

Thanks. This is an unpleasant bug in the rendering algorithm I really need to hunt down...

bgamari commented 11 years ago

I think I've also seen problems along these lines, although I can't recall which models were affected. If I stumble upon one I can post it here if that would be helpful.

julialongtin commented 7 years ago

I think i've hunted down all of the weird spikes.

timthelion commented 7 years ago

Awsome to hear that the bug might be fixed after all this time :D I'm used to having bugs of this age be closed by bots :D

Not sure if I'll test it though...

On 03/07/2017 10:30 PM, Julia Longtin wrote:

I think i've hunted down all of the weird spikes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/colah/ImplicitCAD/issues/64#issuecomment-284865509, or mute the thread https://github.com/notifications/unsubscribe-auth/ABU7-KKP5zhL2v4YpBcsaYKUWsOY7GmKks5rjcxogaJpZM4ALXKA.

julialongtin commented 7 years ago

try the online editor, at http://implicit.faikvm.com/ ? :)

bots are the easy way out. :)

On Tue, Mar 7, 2017 at 9:32 PM, Timothy Hobbs notifications@github.com wrote:

Awsome to hear that the bug might be fixed after all this time :D I'm used to having bugs of this age be closed by bots :D

Not sure if I'll test it though...

On 03/07/2017 10:30 PM, Julia Longtin wrote:

I think i've hunted down all of the weird spikes.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/colah/ImplicitCAD/issues/64#issuecomment-284865509,

or mute the thread https://github.com/notifications/unsubscribe-auth/ABU7- KKP5zhL2v4YpBcsaYKUWsOY7GmKks5rjcxogaJpZM4ALXKA.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/colah/ImplicitCAD/issues/64#issuecomment-284866193, or mute the thread https://github.com/notifications/unsubscribe-auth/AQDAAliTuovGfrArrFT5A3v2ESd21cjXks5rjc0BgaJpZM4ALXKA .