search

Haskell-Things / implicitpipe

OpenGL 3D viewer for ImplicitCAD
MIT License
20 stars 2 forks source link

omolize? #3

Closed fisx closed 11 months ago

fisx commented 3 years ago

I just opened this ImplicitCAD PR, and I'm hoping to find the time to open one for hslice soon.

Is that something you could get excited about? Please feel invited to the debate there.

sorki commented 3 years ago

Yup, I've tried it already for one code base but didn't integrate it into my workflow, mostly used its suggestions to improve few parts but kept some hand-formatted.

Feel free to submit a PR formatted with it - I can take care of nix integration part (and possibly pre-commit hook).

fisx commented 3 years ago

Yup, I've tried it already for one code base but didn't integrate it into my workflow, mostly used its suggestions to improve few parts but kept some hand-formatted.

Feel free to submit a PR formatted with it - I can take care of nix integration part (and possibly pre-commit hook).

Great, thanks! :)

I'll submit a github workflow to https://github.com/colah/ImplicitCAD/pull/376 soon, and I'd love to hear your suggestions, then we can recycle the result here. (I wanted to hack it into ci.dhall, but that looked like it wasn't really supposed to work out of the box, or at least it would take me a lot longer to figure out.)

sorki commented 3 years ago

I've formatted this with stylish-haskell (part of #5) instead which seems to fit my style a bit more and required only a few changes.