search

Hasnayeen / themes

Themes for Filament panels.
MIT License
234 stars 31 forks source link

[Bug]: Duplicated right hand scrollbar #31

Closed DariusIII closed 9 months ago

DariusIII commented 10 months ago

What happened?

After update to latest FilamentPHP version (3.1.23) themes started having a secondary scrollbar on right.

image

This happens on resource edit page that has a relationmanager view below it. Both the relation manager and edit page have separate scrollbars. Every other page looks fine, even the resource manager view page. Issue happens only on edit page.

How to reproduce the bug

Install latest version of this package and currently latest version of filament (3.1.23)

Package Version

3.0.21

Filament Version

3.1.23

PHP Version

8.2.13

Laravel Version

10.37.3

Notes

No response

DariusIII commented 10 months ago

I am not sure, but only thing that could cause this might be this?

https://github.com/filamentphp/filament/pull/10290

royalmediaco commented 10 months ago

I'm not using this theme/package, but this scrollbar bug happens to me using filamentphp tables with bulk actions. It also started with the filamentphp 3.1.23 version.

If I remove bulkActions(), the second scrollbar goes away. Bulk actions in 3.1.22 look fine.

bmckay959 commented 10 months ago

@DariusIII can you try and add this class back by doing "inspect" in the browser to see if that fixes it?

Hasnayeen commented 9 months ago

this issues is fixed by https://github.com/filamentphp/filament/pull/10636