search

HassenPy / django-pdb

Gives you `manage.py runserver --pdb` and `manage.py test --pdb`
394 stars 61 forks source link

Add django1.7 compaitibilty #24

Closed jpulec closed 9 years ago

jpulec commented 9 years ago

Make a backwards compatible change to use new app loading if using django 1.7, or fall back to the old find_management_module way if django < 1.7

jpulec commented 9 years ago

Hey Tom. I know you're super busy with DRF3 these days, but just wondering if you saw this. Keep up the great work!

tomchristie commented 9 years ago

@jpulec Howdy. Weighing up if it's worth rolling out further pypi releases of this package, or if I should just punt it into 'unmaintained' state. Could switch over maintainership if you'd be up for taking care of it?

jpulec commented 9 years ago

I would definitely be willing to maintain it, especially if the alternative means it being abandoned.

tomchristie commented 9 years ago

@jpulec - Added you as a collaborator. There's only a handful of outstanding PRs/Issues so once those are reviewed just ping me and can add you to PyPI maintainership as well.

jpulec commented 9 years ago

Finally got around to this, and it should all just work. Awesome.

tomchristie commented 9 years ago

:+1:

jpulec commented 9 years ago

@tomchristie All pull requests have been reviewed and we should be ready to push out a new version of django-pdb that works with Django 1.7.

tomchristie commented 9 years ago

@jpulec Okey doke - want to set up a PyPI account if you haven't already, and let me know your username. I'll add you as an admin on the account.

jpulec commented 9 years ago

@tomchristie Sure. My PyPI account is just 'jpulec' .

tomchristie commented 9 years ago

@jpulec Added. Should just be setup.py publish now.

blueyed commented 9 years ago

Is this still meant to work for "runserver"?

django_pdb/management/commands/runserver.py never gets imported for me, but it works for .../test.py.

blueyed commented 9 years ago

See https://github.com/tomchristie/django-pdb/pull/28