search

HassenPy / django-pdb

Gives you `manage.py runserver --pdb` and `manage.py test --pdb`
394 stars 61 forks source link

Issue #41: Fix MIDDLEWARE_CLASSES error with `runserver` #42

Closed gh640 closed 6 years ago

gh640 commented 6 years ago

This is a small PR to address #41.

I read the contributing guide ( https://github.com/HassenPy/django-pdb/blob/master/CONTRIBUTING.md )but I couldn't judge if I may send PR or not in this case. I'm sorry if I disturb you with this PR.

After applying this change, I could use this package with Django 2.0.2.

Also, (in #40 ) I found you are planning to rewrite whole code. If you don't take PR for now to rewrite the project, please don't hesitate to reject this.

Also, I'm planning to rewrite the whole project,

Thank you in advance.

HassenPy commented 6 years ago

Welcome @gh640 and thanks, i already started refactoring the project, not sure when i ll finish thou, i inherited the contribution guide and changed it locally, i ll try to update the project asap.

hmm that seems to fix the error but it doesn't seem to fix the --pdb or --ipdb arguments not being discovered, from what i remember the whole management module needs rewriting, i can merge that for now to silence the error, however i'm still unable to reproduce the error, i tried with the same versions as you did but didn't get the error.

HassenPy commented 6 years ago

probably failing to reproduce since the pdb/ipdb arguments are not being picked, i ll try to finish the refactoring asap, i already have some work done but still figuring the best way to keep this project testable, i thought about a branch for every major version and the master branch will always be the latest version after a Django breaking change to Middleware, management commands or template tags.

HassenPy commented 6 years ago

if anyone is in urgent need for this you can install @gh640's version with:
pip install git+https://github.com/gh640/django-pdb

gh640 commented 6 years ago

@HassenPy thank you for you response and taking the time to review the PR.

Actually I tested the function with pdb GET parameter which is different from the case you tested. As with the issue of option --pdb and --ipdb you told, I'll try investigating them.

Anyway, thank you for all of your work!

gh640 commented 6 years ago

@HassenPy thank you for processing this!

I tested the option --pdb and --ipdb in my environment and it seems to work well... If I find any issue using this package, I'll let you know. Thank you for your swift and kind reaction :)