search

HatScripts / circle-flags

A collection of 400+ minimal circular SVG country, state and language flags
https://hatscripts.github.io/circle-flags
MIT License
945 stars 249 forks source link

Fix CV flag #1

Closed waldyrious closed 4 years ago

waldyrious commented 4 years ago

The flag of Cape Verde had the stripes and stars positioned too low. The top blue part is supposed to occupy half of the height of the flag. I've edited the geometry so that the white and red stripes start at 50% of height of the circle. I moved the stars upwards accordingly.

See https://en.wikipedia.org/wiki/Flag_of_Cape_Verde for details.

Reference image:

Before After
Screen Shot 2020-06-05 at 00 00 00 Screen Shot 2020-06-05 at 00 54 13
waldyrious commented 4 years ago

Actually, I should make the stripes larger, since the bottom blue part should only occupy the lower quarter of the flag. That would also help in making the flag elements more visible at small sizes. I'll hold off on making these changes, though, until I get initial feedback on this PR.

HatScripts commented 4 years ago

Thanks for the fix, @waldyrious! Already looks a lot better. And indeed you're right that the ratios would be more accurate if the stripes were upscaled to take up a quarter of the flag's height. You're welcome to make any further updates. :)

waldyrious commented 4 years ago

I will submit a new PR with the additional fixes soon :)