HatScripts / circle-flags

A collection of 400+ minimal circular SVG country, state and language flags
https://hatscripts.github.io/circle-flags
MIT License
928 stars 248 forks source link

Klingon flag #12

Closed Shatur closed 3 years ago

Shatur commented 3 years ago

Hello! Could you add Klingon flag? I am working on a translator application that has this language and it would be nice to present it with a flag :)

HatScripts commented 3 years ago

Hey Shatur, there's actually already a Klingon flag, tucked away in /flags/fiction.

Klingon circle-flag

In fact, it's currently the only flag in that directory. At the time I was planning on adding other fictional flags, especially those which also represent a language.

Also, please bear in mind that if you were planning on using the hatscripts.github.io/... link directly, that the klingon.svg file may at some point be migrated to the currently non-existent /flags/language/fiction directory.

Shatur commented 3 years ago

Oh, missed it, thank you!

file may at some point be migrated to the currently non-existent /flags/language/fiction directory.

Thanks for the info. I am working on a desktop application and icons will be bundled at specific commit from this repo using CMake build system. I will of course keep the icons up to date, but any changes will not accidently broke the icons in the app :)

P.S. Here is the app.

P.P.S. Could you draft a release? This would allow me to hook the tag instead of commit.

HatScripts commented 3 years ago

P.S. Here is the app.

Looks very nice! Will definitely be trying this out.

P.P.S. Could you draft a release? This would allow me to hook the tag instead of commit.

Sure thing, not sure why I hadn't already done that. 🤔 https://github.com/HatScripts/circle-flags/releases/tag/v1.0.0

Shatur commented 3 years ago

Thanks!