search

HatScripts / circle-flags

A collection of 400+ minimal circular SVG country, state and language flags
https://hatscripts.github.io/circle-flags
MIT License
928 stars 248 forks source link

Correct proportions and colours for the Spanish flag #16

Closed ramongilmoreno closed 3 years ago

ramongilmoreno commented 3 years ago

Correct proportions for the Spanish flag, as defined here:

Real Decreto 441/1981, de 27 de febrero, por el que se especifican técnicamente los colores de la Bandera de España. https://www.boe.es/eli/es/rd/1981/02/27/441

Colors approximated as described in the Wikipedia here: https://es.wikipedia.org/wiki/Bandera_de_España#Colores

Explanation on colors approximation here: https://rafamerino.com/11062020/colores-bandera-espana-hexadecimal-rgb

ramongilmoreno commented 3 years ago

Hello Tomás.

I have uploaded circle + path version of the flag in this commit: https://github.com/ramongilmoreno/circle-flags/commit/754749e48d5feac3a29bdb48fb7857fa7b09e4e5

Now the structure of the SVG is similar to other flags in the project. Format of the flag is less obvious but I actually dislike the fact of having elements with id in the SVG body.

Hope it helps Ramón Gil Moreno

tnovau commented 3 years ago

Hi Ramón, did you execute svgo?

I am only contributor here.

@HatScripts and @waldyrious should look this PR 👍🏼

ramongilmoreno commented 3 years ago

Hi @tnovau

Thanks for the note.

I thought svgo was to be run locally by users rather than at commit time. My bad as the instructions are clear.

I run it and uploaded the results in commit https://github.com/ramongilmoreno/circle-flags/commit/491be30df8a4142add4b6772b085482c7d16ec80

Ramón

P.S. Note that the French Guiana gf.svg flag was also affected by the svgo run; but choose to not include that change in the commit as it is out of the PR scope.

tnovau commented 3 years ago

Thanks for letting us know. I will fix it in another PR

ramongilmoreno commented 3 years ago

Hello there HatScripts

I understand your motivations.

So, in summary, if you could please change the colors from #aa151b/#f1bf00 back to #d80027/#ffda44 then I can gladly approve this PR.

I have uploaded these modification in commit https://github.com/ramongilmoreno/circle-flags/commit/415b11fa9210a32044b8b36f2bbe5240a8df0c89 to adhere to the current project palette.

HatScripts commented 3 years ago

Thanks Ramón, merged! 😄🚀

ramongilmoreno commented 3 years ago

Thanks to you for the great project.