Closed climech closed 3 years ago
Wow, this looks utterly amazing! How long did all this take you? That build script looks awesome too, and all the added documentation to go along with it. Seriously cool!
I've looked through the minor changes too and they all look to be good and up to scratch. I'll have a peruse through the full list of flags when I'm able to and report back to you. 😄
Sure thing, glad you like it!
It took me about a week, and I became super-proficient at Inkscape keyboard shortcuts in the process 😄. I really wanted to use the flags in one of my projects, but the rendering artifacts were a big itch for me 😅
Edit: Thanks for the invite btw!
It took me about a week, and I became super-proficient at Inkscape keyboard shortcuts in the process 😄. I really wanted to use the flags in one of my projects, but the rendering artifacts were a big itch for me 😅
Ah I see, that makes sense. They were a big itch for a lot of people it seemed, haha. Thank you once again for your awesome contribution to the repo. Merged 😄🚀
Fix color-bleeding issues (all flags)
This updates all 276 icons to remove (hopefully) all color-bleeding artifacts, both at the outer edges and inside. It was done by squaring all the icons, overlapping the shapes where needed, and finally applying a circular mask to all files using a custom script.
The artifacts were particularly visible on dark backgrounds at lower resolutions, e.g.:
<mask>
was chosen over<clipPath>
because the former results in slightly smaller file sizes (exactly 1 byte smaller 🙃).The icons now follow a predictable structure:
This also applies to flags with uniformly-colored edges such as
jp.svg
, where the mask doesn't make any difference as far as fixing any artifacts. It does however make the icons easier to work with programmatically, and the overall size difference after the update is very small (+1.6%).Because the shapes invariably conform to a square now, it becomes possible to change the shape of the mask to something else, e.g. a square with rounded corners:
Size difference
Minor changes
These flags were found to be slightly malformed (not perfectly circular) which is now fixed: