search

HatScripts / circle-flags

A collection of 400+ minimal circular SVG country, state and language flags
https://hatscripts.github.io/circle-flags
MIT License
928 stars 248 forks source link

These flags are missing #21

Closed bastien70 closed 3 years ago

bastien70 commented 3 years ago

Hey! I use this library with the CountryType field of Symfony.

Unfortunately, it seems that some flags are missing. Here is the list :

sh : Saint Helena mf : Saint-Martin pm : Saint Pierre and Miquelon wf : Wallis and futuna tf : Southern French lands sj: Svalbard and Jan Mayen bq : Caribbean Netherlands nc : New Caledonia yt : Mayotte re : La Réunion um : United States Minor Outlying Islands hm : Heard and MacDonald Islands bv : Bouvet Island gp : Guadeloupe gs : South Georgia and the South Sandwich Islands aq : Antarctic

image

HatScripts commented 3 years ago

Hi @bastien70, thanks for pointing these out. I've started working on adding them. Not all of these countries and dependent territories have their own official flags, but most have unofficial ones.

The following seem to always use the same flags as their administrative countries, so it might make sense to create symlinks for these:

For bq and sh, I think it would be best to split them up into their ISO_3166-2 subdivisions, because each island/municipality has its own flag:

I can see that @waldyrious has already set the template in the flags gallery like this for sh.

bastien70 commented 3 years ago

The problem is that if you do not respect the real 2 character code, it will cause problem for association with the Country field of the Symfony framework.

Or, it will require customization work on this field so that it adapts to your codes for the "countries" concerned.

Afterwards, these are most certainly countries that we will never use, but that can have an impact only from an aesthetic point of view.

The choice is therefore difficult

HatScripts commented 3 years ago

I see, well to work around that, perhaps it would be best to also create the following symlinks:

Following the conventions of emoji:

bastien70 commented 3 years ago

This means that if we call the following link: https://hatscripts.github.io/circle-flags/flags/sh.svg it will render the sh-hl flag ?

HatScripts commented 3 years ago

Yes, that is correct. :)

bastien70 commented 3 years ago

Yes, that is correct. :)

So that's a very good idea! I look forward :p

doublex commented 3 years ago

@HatScripts Great news! Thanks for adding

doublex commented 3 years ago

Maybe: AC BQ CP DG EA GP GS IC MF NC PM RE SH TA TF WF YT

doublex commented 3 years ago

Very helpful would be: (referenced in Unicode CLDR):

SH - Saint Helena AC - Ascension Island TA - Tristan da Cunha GS - South Georgia & South Sandwich Islands

Maybe rename: ES-CN -> ES-IC https://www.iso.org/obp/ui/#iso:code:3166:IC

HatScripts commented 3 years ago

Maybe rename: ES-CN -> ES-IC https://www.iso.org/obp/ui/#iso:code:3166:IC

I was basing the naming convention for ES-CN on Wikipedia: https://en.wikipedia.org/wiki/ISO_3166-2:ES#Autonomous_communities;_autonomous_cities_in_Spain, which in turn references https://www.iso.org/obp/ui/#iso:code:3166:ES

HatScripts commented 3 years ago

All the flags @bastien70 mentioned have now been added:

doublex commented 3 years ago

@HatScripts Thanks for the effort.