Fix flag filenames - Githubissues

HatScripts / circle-flags

A collection of 400+ minimal circular SVG country, state and language flags

https://hatscripts.github.io/circle-flags

MIT License

928 stars 248 forks source link

Fix flag filenames #6

Closed waldyrious closed 4 years ago

waldyrious commented 4 years ago

Fix filename of Ceuta flag: ea.svg → es-ce.svg
Fix typo in name of Northern Cyprus flag: "northen" → "northern"

waldyrious commented 4 years ago

@HatScripts I'd like to also ask your opinion about using alphabetic HASC codes instead of ISO subdivision codes in the cases where the latter are numeric. For the flags currently in the repo, that would mean changing the following:

Portugal
- Azores: pt-20.svg → pt-ac.svg
- Madeira: pt-30.svg → pt-ma.svg
Italy
- Sicily: it-82.svg → it-sc.svg
- Sardinia: it-88.svg → it-sd.svg

WDYT?

HatScripts commented 4 years ago

Thanks for the fixes. :)

I'd like to also ask your opinion about using alphabetic HASC codes instead of ISO subdivision codes in the cases where the latter are numeric.

Hmm, such changes, while more pleasing on the eyes, could get a little confusing in the future. For instance in ISO_3166-2, IT-SD represents the province of South Sardinia, not Sardinia itself. Not that South Sardinia appears to have a flag, but that's just one example of a collision. How would you propose we overcome such collisions?

waldyrious commented 4 years ago

Oh, right, I didn't realize the ISO codes for Italy's subdivisions had both numeric and alphabetic extensions. Nice catch! I agree that avoiding the numeric codes is a minor concern, especially now that there's more explicit documentation via the gallery page, so let's continue using only ISO to keep things simple. 👍