search

HatScripts / circle-flags

A collection of 400+ minimal circular SVG country, state and language flags
https://hatscripts.github.io/circle-flags
MIT License
985 stars 256 forks source link

Added flags of DPR and LPR #91

Closed shankarsivarajan closed 1 year ago

shankarsivarajan commented 1 year ago

Added flags of the disputed Donetsk and Luhansk People's Republics.

HatScripts commented 1 year ago

Done! 0cfe5e2 - Thanks for the PR, @shankarsivarajan.

Accessible at ru-dpr.svg and ru-lpr.svg.

waldyrious commented 1 year ago

Hey @HatScripts -- I've noticed that you have been incorporating PRs as separate commits authored by you, even when the actual SVG code is identical (AFAICT) to the versions in the PRs. Is there a reason for this? Perhaps to reduce proliferation of authors to avoid complex licensing issues down the road? Or simply convenience? Just curious :)

shankarsivarajan commented 1 year ago

The effort required to check that the svg code is "correct" (i.e., correctly optimized, follows the color palette, is exactly symmetric if it's supposed to be), at least for the more complicated flags, is probably as much as just redoing it. Some of my earlier PRs were bad, and I'm glad he didn't merge them.

HatScripts commented 1 year ago

@waldyrious It's mainly for convenience. I'm a bit of a perfectionist when it comes to making sure the flags are "correct", as @shankarsivarajan put it:

correctly optimized, follows the color palette, is exactly symmetric if it's supposed to be

waldyrious commented 1 year ago

Thanks both for the clarifications! Makes sense :)

Still, I would personally add the PR authors as co-authors in the commits, just in the interest of keeping the record in the git repository itself, rather than only in the hosting service (GitHub). You can actually do it directly in the commit command, since git 2.32:

git commit -m "Commit message" --trailer "Co-authored-by: John Doe <john.doe@email.com>"

(But of course, this is a little cumbersome and I totally understand if you prefer to do things in the simpler way to be more agile.)