search

HathorNetwork / hathor-core

Hathor core is the official and reference client for operating a full node in Hathor Network.
https://hathor.network
Apache License 2.0
83 stars 26 forks source link

Merged mining with Antminer failed, more investigation needed #11

Closed jansegre closed 4 years ago

jansegre commented 5 years ago

This blocks #3

jansegre commented 5 years ago

After some investigation it appears that we're calculating the difficulty incorrectly.

In practice mining should still work though most shares will be rejected. The result of those shares is actually used though and it stills contributes to the network.

But this is definitely not how it should work. I'm already testing a fix and maybe I'll manage to update the network today.

jansegre commented 5 years ago

Just some heads up: after the difficulty calculation was fixed there were more tests but other problems arose. There was a stratum extension (mininig.configure) the server did not implement and caused the Antminer not to connect. The initial implementation that naively answer that no configuration could be set (instead of method not found) only briefly solved the problem. I suspected that a particular configuration (minimum difficulty) was the cause of the latest concern, that configuration has been implemented but tests have yet to be made.

jansegre commented 4 years ago

This new MR fixes the existing issues I've found so far: https://gitlab.com/HathorNetwork/hathor-python/merge_requests/361

obiyankenobi commented 4 years ago

Fixed with https://gitlab.com/HathorNetwork/hathor-python/-/merge_requests/361