HathorNetwork / hathor-core

Hathor core is the official and reference client for operating a full node in Hathor Network.
https://hathor.network
Apache License 2.0
83 stars 26 forks source link

chore(benchmark): improve benchmark CI #1112

Closed glevco closed 1 month ago

glevco commented 1 month ago

Motivation

Benchmark on CI was sometimes failing when the server node would take some time to start sending blocks to the benchmark node, causing an increase in the measured time. Adding a warmup run to hyperfine fix this as it is discarded, and then the two following runs are valid.

I also noticed the large waiting times for the download step (20 min) was caused by cache not being set in the full node. I added it and it now takes 2 min.

Acceptance Criteria

Checklist

github-actions[bot] commented 1 month ago

🐰Bencher

ReportMon, August 19, 2024 at 16:13:19 UTC
Projecthathor-core
Branchchore/improve-bench
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,650,896,060.40 (-1.68%)82,708,741,756.12 (81.37%)124,063,112,634.18 (81.93%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 84.93%. Comparing base (3681579) to head (ce1d899). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1112 +/- ## ========================================== + Coverage 84.91% 84.93% +0.01% ========================================== Files 315 315 Lines 24070 24070 Branches 3647 3647 ========================================== + Hits 20439 20443 +4 + Misses 2921 2918 -3 + Partials 710 709 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.