Closed glevco closed 1 month ago
Report | Mon, August 19, 2024 at 16:13:19 UTC |
Project | hathor-core |
Branch | chore/improve-bench |
Testbed | ubuntu-22.04 |
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,650,896,060.40 (-1.68%) | 82,708,741,756.12 (81.37%) | 124,063,112,634.18 (81.93%) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.93%. Comparing base (
3681579
) to head (ce1d899
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
Benchmark on CI was sometimes failing when the server node would take some time to start sending blocks to the benchmark node, causing an increase in the measured time. Adding a warmup run to hyperfine fix this as it is discarded, and then the two following runs are valid.
I also noticed the large waiting times for the download step (20 min) was caused by cache not being set in the full node. I added it and it now takes 2 min.
Acceptance Criteria
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged