HathorNetwork / hathor-core

Hathor core is the official and reference client for operating a full node in Hathor Network.
https://hathor.network
Apache License 2.0
83 stars 26 forks source link

refactor(p2p): rename peer_id.PeerId to peer.Peer #1113

Closed jansegre closed 1 month ago

jansegre commented 1 month ago

Motivation

This is the first part of a series of refactors. This first refactor is a step to make using PeerId for only the id part of Peer.

Acceptance Criteria

Checklist

github-actions[bot] commented 1 month ago

🐰Bencher

ReportThu, August 22, 2024 at 14:04:50 UTC
Projecthathor-core
Branchrefactor/p2p-rename-peer-id
Testbedubuntu-22.04
Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Lower Boundary
nanoseconds (ns) | (%)
Latency Upper Boundary
nanoseconds (ns) | (%)
sync-v2 (up to 20000 blocks)✅ (view plot)101,385,519,316.14 (-1.46%)92,595,867,200.35 (91.33%)113,172,726,578.21 (89.58%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.41667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 84.91%. Comparing base (e85e4be) to head (f2c436f). Report is 2 commits behind head on master.

Files Patch % Lines
hathor/p2p/peer.py 50.00% 4 Missing :warning:
hathor/builder/builder.py 83.33% 1 Missing and 1 partial :warning:
hathor/p2p/states/ready.py 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1113 +/- ## ========================================== + Coverage 84.86% 84.91% +0.05% ========================================== Files 315 315 Lines 24071 24071 Branches 3647 3647 ========================================== + Hits 20427 20440 +13 + Misses 2931 2920 -11 + Partials 713 711 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.