Closed jansegre closed 1 month ago
Report | Thu, August 22, 2024 at 14:04:50 UTC |
Project | hathor-core |
Branch | refactor/p2p-rename-peer-id |
Testbed | ubuntu-22.04 |
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,385,519,316.14 (-1.46%) | 92,595,867,200.35 (91.33%) | 113,172,726,578.21 (89.58%) |
Attention: Patch coverage is 85.41667%
with 7 lines
in your changes missing coverage. Please review.
Project coverage is 84.91%. Comparing base (
e85e4be
) to head (f2c436f
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
hathor/p2p/peer.py | 50.00% | 4 Missing :warning: |
hathor/builder/builder.py | 83.33% | 1 Missing and 1 partial :warning: |
hathor/p2p/states/ready.py | 66.66% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
This is the first part of a series of refactors. This first refactor is a step to make using
PeerId
for only theid
part ofPeer
.Acceptance Criteria
hathor.p2p.peer_id.PeerId
tohathor.p2p.peer.Peer
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged