Closed glevco closed 4 weeks ago
Report | Thu, September 5, 2024 at 15:22:31 UTC |
Project | hathor-core |
Branch | feat/improve-load-from-logs |
Testbed | ubuntu-22.04 |
Benchmark | Latency | Latency Results nanoseconds (ns) | (Δ%) | Latency Lower Boundary nanoseconds (ns) | (%) | Latency Upper Boundary nanoseconds (ns) | (%) |
---|---|---|---|---|
sync-v2 (up to 20000 blocks) | ✅ (view plot) | 101,409,921,726.48 (-0.77%) | 91,981,574,820.96 (90.70%) | 112,421,924,781.17 (90.20%) |
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.41%. Comparing base (
50ae3b2
) to head (0703970
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
Currently, the
load-from-logs
CLI command reads a raw logs file as outputted by a full node. This PR changes it so instead you have to process the log file with theparse-logs
command, only then to use it withload-from-logs
. This makes the log files much smaller, as the parser strips every information but the vertex bytes.Also, previously that command only called
on_new_tx
in a loop, but didn't actually run the reactor or the full node itself. This PR also changes this.The new intended workflow would be something like this:
Acceptance Criteria
parse-logs
CLI command.load-from-logs
CLI command so it takes files fromparse-logs
and so it actually runs a full node.Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged