ci: tests for network statistics api - Githubissues

HathorNetwork / hathor-explorer-service

MIT License

1 stars 3 forks source link

ci: tests for network statistics api #283

Closed luislhl closed 11 months ago

luislhl commented 11 months ago

Acceptance Criteria

Add some unit tests for the network statistics API logic added in https://github.com/HathorNetwork/hathor-explorer-service/pull/268

Motivation

We've been getting errors in the coverage check because we've dropped below 90%.

Security Checklist

[ ] Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

luislhl commented 11 months ago

Also: shouldn't we add the test coverage to the PR context as well? Like what we have with the wallets repositories and the Codecov tool.

@tuliomir , I think that's a good idea, but I think it fits better in a new PR. This one was just to fix the "emergency" of having the CI failing because of the coverage.

Adding Codecov would be something else.