HathorNetwork / hathor-wallet-mobile

Hathor official mobile wallet
https://hathor.network/
MIT License
26 stars 24 forks source link

feat: add SES to wallet-mobile #420

Closed andreabadesso closed 1 week ago

andreabadesso commented 9 months ago

Motivation

We want to defend against supply chain attacks as those kind of attacks have already hit the cryptocurrency ecosystem and present a significant risk for our developers and users of our wallets and apps.

This PR is part of a series of PRs using a set of tools called LavaMoat to improve security on our Javascript projects with a set of good defaults, preventing us from having to rewrite them from scratch

Important: SES is not yet fully compatible with react-native, there is a compatibility tracker issue here

What is not yet supported (that affect us)?

Also, to prevent multiple patches in react-native, we had to inject SES in a patch to react-native's initializeCore method, so it gets loaded before anything else in our bundle

Acceptance Criteria

Security Checklist

naugtur commented 9 months ago

Hi. I think we could chat about what we're working on in LavaMoat. Get in touch if you think so too :)

andreabadesso commented 9 months ago

Hi. I think we could chat about what we're working on in LavaMoat. Get in touch if you think so too :)

Hey @naugtur, thanks for reaching out!

I've just sent you a DM on twitter, please tell me if this is the best way to contact you

naugtur commented 7 months ago

Update on our progress:

BTW Consider just switching to socketsupply.co