refactor: fetchHistory on sagas/nanoContract to avoid iteration suspension - Githubissues

HathorNetwork / hathor-wallet-mobile

Hathor official mobile wallet

https://hathor.network/

MIT License

24 stars 24 forks source link

refactor: fetchHistory on sagas/nanoContract to avoid iteration suspension #569

Closed alexruzenhack closed 1 month ago

alexruzenhack commented 1 month ago

Motivation

This PR closes https://github.com/HathorNetwork/hathor-wallet-mobile/issues/514 to add concurrency on isAddressMine calls without mess with history ordering.

Acceptance Criteria

Refactor fetchHistory to avoid iteration suspension while hydrating the NcTxHistory item with isMine flag
As the isAddressMine is an O(1) call and don't require a http request, we can use a plain Promise.all to collect the tasks

fetchHistory still working properly

https://github.com/user-attachments/assets/fdd10982-f498-45d6-b4d5-f7c0215a526a

Security Checklist

[ ] Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.