HathorNetwork / hathor-wallet-service-old

MIT License
4 stars 4 forks source link

fix: throw error when htr is requested on getTokenDetails #377

Closed andreabadesso closed 1 year ago

andreabadesso commented 1 year ago

Motivation

Since we now have htr on our token table, we should ignore it on getTokenDetails to prevent unnecessary database queries when it is requested

Fixes https://github.com/HathorNetwork/on-call-incidents/issues/87

Acceptance Criteria

Security Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #377 (c3a2f3c) into dev (790bf87) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #377      +/-   ##
==========================================
+ Coverage   94.75%   94.76%   +0.01%     
==========================================
  Files          37       37              
  Lines        2308     2313       +5     
  Branches      270      271       +1     
==========================================
+ Hits         2187     2192       +5     
  Misses        121      121              
Impacted Files Coverage Δ
src/api/tokens.ts 100.00% <100.00%> (ø)
src/api/utils.ts 96.66% <100.00%> (+0.23%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.