HathorNetwork / hathor-wallet-service-old

MIT License
4 stars 4 forks source link

fix: parse firebase private key env #386

Closed alexruzenhack closed 1 year ago

alexruzenhack commented 1 year ago

Acceptance Criteria

A direct deployment using the serverless API does not interfere with ENV values. However, a deployment through the CI pipeline interferes with ENV values by escaping them. To reverse this effect we need to restore its original value.

Security Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #386 (31db4d3) into dev (23cacf8) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #386      +/-   ##
==========================================
+ Coverage   95.40%   95.41%   +0.01%     
==========================================
  Files          37       37              
  Lines        2329     2336       +7     
  Branches      274      276       +2     
==========================================
+ Hits         2222     2229       +7     
  Misses        107      107              
Impacted Files Coverage Δ
src/utils/pushnotification.utils.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.