HathorNetwork / hathor-wallet-service-old

MIT License
4 stars 4 forks source link

chore: add manual deploy for dev-testnet environment #387

Closed alexruzenhack closed 1 year ago

alexruzenhack commented 1 year ago

Acceptance Criteria

This addition in the CD pipeline aims to test a delivery passing through all the CI/CD pipeline.

Security Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #387 (ac608e7) into dev (1a29030) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ac608e7 differs from pull request most recent head faf1c1f. Consider uploading reports for the commit faf1c1f to get more accurate results

@@           Coverage Diff           @@
##              dev     #387   +/-   ##
=======================================
  Coverage   95.40%   95.40%           
=======================================
  Files          37       37           
  Lines        2329     2329           
  Branches      274      274           
=======================================
  Hits         2222     2222           
  Misses        107      107           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

luislhl commented 1 year ago

With the proposed changes, we will have something like:

if (...)
[...]

if (...)
[...]
elif (...)
[...]
else
[...]

We need to join the first if to the if..elif..else chain as well, otherwise the dev branch will be always deployed 2 times.

Deleting the first if would have the same result.