HathorNetwork / hathor-wallet-service-old

MIT License
4 stars 4 forks source link

fix: invalid cron schedules #403

Closed andreabadesso closed 1 year ago

andreabadesso commented 1 year ago

Acceptance Criteria

Security Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #403 (a164af9) into dev (301b563) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #403   +/-   ##
=======================================
  Coverage   95.50%   95.51%           
=======================================
  Files          40       40           
  Lines        2404     2408    +4     
  Branches      269      270    +1     
=======================================
+ Hits         2296     2300    +4     
  Misses        108      108           
Impacted Files Coverage Δ
src/db/cronRoutines.ts 80.76% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

alexruzenhack commented 1 year ago

Should we have debug logs like Starting execution or Ending with success just to have some logs to watch for? Does it worth something as a practice or not?

andreabadesso commented 1 year ago

Should we have debug logs like Starting execution or Ending with success just to have some logs to watch for? Does it worth something as a practice or not?

We already have those, AWS logs when the requests starts and ends:

image

alexruzenhack commented 1 year ago

Should we have debug logs like Starting execution or Ending with success just to have some logs to watch for? Does it worth something as a practice or not?

We already have those, AWS logs when the requests starts and ends:

image

Ok. I will apply this in further situations as well.