Hats-Protocol / hats-protocol

Core contracts for Hats Protocol v1.0
https://www.hatsprotocol.xyz
GNU Affero General Public License v3.0
79 stars 25 forks source link

Topo's audit fixes #98

Closed topocount closed 1 year ago

topocount commented 1 year ago

Rather than adding any checks, it's just cheaper to accomodate more depth. This is relatively arbitrary imo. I chose uint8 because I had a hard time imagining any org reaching that size on V1, but breaking for such a silly reason, is poor form, unless we add explicit contraints for nested tree depth.

spengrah commented 1 year ago

Agreed, this is the right approach imo. Cleaner, less opinionated, and cheaper. lgtm